svn commit: r308655 - in head/games/xmoto: . files

[Baptiste Daroussin]

On Tue, Dec 11, 2012 at 05:21:28PM +0400, Dmitry Marakasov wrote:
> * Alexey Dokuchaev (danfe at FreeBSD.org) wrote:
> > On Tue, Dec 11, 2012 at 03:14:14AM +0000, Dmitry Marakasov wrote:
> > > New Revision: 308655
> > > URL: http://svnweb.freebsd.org/changeset/ports/308655
> > > 
> > > +OPTIONS_DEFINE=	ASIAN_TTF
> > >  
> > > [...]
> > >  
> > > +.if ${PORT_OPTIONS:MNLS}
> > > [...]
> > > +.if ${PORT_OPTIONS:MDOCS}
> > 
> > Looks like these two should also be mentioned in OPTIONS_DEFINE.
> 
> Not adding them to OPTIONS_DEFINE preserves previous behaviour and I
> don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are
> only meaningful to be set globally, and having them in individual ports
> makes large builds much more painful, as a user has to set them for tons
> of ports (even more painful without portmaster or knowing of
> config-recursive).

My opinion on this is if you have already an OPTIONS_DEFINE it means that the
dialog(1) will be shown anyway so it doesn't hurt to add NLS and DOCS to it.

if you do not have OPTIONS_DEFINE for something else then yes I can understand
you don't want to bother users with dialog coming up all the time.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20121211/ea68ebd4/attachment.sig>