svn commit: r308217 - in head/devel/icmake: . files

[Jason E. Hale]

On Tuesday, December 04, 2012 13:23:41 Gabor Pali wrote:
> On Tue, Dec 4, 2012 at 12:45 PM, Jason E. Hale <jhale at freebsd.org> wrote:
> 
> >>  .if !defined(NOPORTDOCS)
> > 
> > Should convert to ${PORT_OPTIONS:MDOCS}
> 
> Hrm, I did not find any authoritative guidance on this.  Once I asked
> bapt about this, and he told me that keeping NOPORTDOCS is okay, if I
> recall correctly.
> 
Maybe bapt can comment, but we seem to be converting everything to OPTIONSng.  
This includes NOPORTDOCS, NOPORTEXAMPLES, WITHOUT_NLS, etc.  AFAIK the prioity 
is to convert ports that use the old OPTIONS, but it would be good to convert 
the other variables as well if the opportunity arises.
http://wiki.freebsd.org/Ports/Options/ConvertingToOptionsNG
includes a check for all of those.

> >> -WWW: http://icmake.sourceforge.net/
> >> +WWW: http://icmake.sourceforge.net/
> > 
> > Why the change to tab?  Single space is the standard.
> 
> Why not? :-)  I use tabs after "WWW:" in pkg-descr for all of my
> ports.  Is this in the Porter's Handbook?
> 
danfe pretty much covered this.  The example in PH also shows single space:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-
desc.html#AEN95

> >>  @comment $FreeBSD$
> > 
> > ^ This isn't neccessary.  Tools/scripts/psvn should be used to set the
> > props correctly.
> 
> Yes, I know, but this is also kind of a habit that I maintain for my
> ports.  Does it cause any problems?
>
I have seen this used as a workaround for incorrect svn props and I assumed 
that is what this was.  I don't know that it causes problems exactly, but it 
is certainly non-standard which makes curious people like me question why it 
is there. :)

http://wiki.freebsd.org/PortsSubversionPrimer says the props for pkg-* should 
be: svn:eol-style=native; fbsd:nokeywords=yes; svn:mime-type=text/plain
so I'm extrapolating that the FreeBSD keyword should not be in there.

-- 
Jason E. Hale - jhale@
FreeBSD Ports Committer
KDE/FreeBSD Team