svn commit: r308151 - head/devel/p5-Exception-Class

Greg Larkin glarkin at FreeBSD.org
Mon Dec 3 14:13:05 UTC 2012


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/3/12 8:48 AM, Frederic Culot wrote:
> Author: culot Date: Mon Dec  3 13:48:25 2012 New Revision: 308151 
> URL: http://svnweb.freebsd.org/changeset/ports/308151
> 
> Log: - Shorten COMMENT description
> 
> Suggested by:	danfe@ Feature safe:	yes
> 
> Modified: head/devel/p5-Exception-Class/Makefile
> 
> Modified: head/devel/p5-Exception-Class/Makefile 
> ==============================================================================
>
> 
- --- head/devel/p5-Exception-Class/Makefile	Mon Dec  3 13:33:29 2012
(r308150)
> +++ head/devel/p5-Exception-Class/Makefile	Mon Dec  3 13:48:25 2012
> (r308151) @@ -7,7 +7,7 @@ MASTER_SITES=	CPAN PKGNAMEPREFIX=	p5-
> 
> MAINTAINER=	perl at FreeBSD.org -COMMENT=	Module that allows you to
> declare real exception classes in Perl +COMMENT=	Module that allows
> to declare real exception classes in Perl
> 
> LICENSE=	ART20
> 
> 

The COMMENT is no longer well-formed English grammar.  I suggest
reverting the change or perhaps rewriting it to something more
concise, such as "Module that declares real exception classes in Perl"
or "Real exception classes in Perl".

How much port description rewriting should be done beyond the
suggestions in the Porter's Handbook
(http://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-comment)?
 I don't have a problem with the original comment, including the word
"you", and in this case it seems more of a PITA to rewrite it to omit
that word and result in correct English.

Thoughts?

Regards,
Greg

- -- 
Greg Larkin

http://www.FreeBSD.org/           - The Power To Serve
http://www.sourcehosting.net/     - Ready. Set. Code.
http://twitter.com/cpucycle/      - Follow you, follow me
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Darwin)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iEYEARECAAYFAlC8s18ACgkQ0sRouByUApB11ACcCN9iw6GiymrWNxVRk5KmAd+2
j24AnROtu9tXeu4eIK+zys/gfH4KpD5x
=Jq5H
-----END PGP SIGNATURE-----


More information about the svn-ports-all mailing list