svn commit: r308132 - head/audio/amrcoder

[Pietro Cerutti]

On 2012-Dec-03, 10:50, Alexey Dokuchaev wrote:
> On Mon, Dec 03, 2012 at 10:34:51AM +0000, Pietro Cerutti wrote:
> > New Revision: 308132
> > URL: http://svnweb.freebsd.org/changeset/ports/308132
> > 
> > @@ -23,4 +18,7 @@ MANCOMPRESSED=	yes
> >  post-extract:
> >  	@${RM} ${WRKSRC}/*.o
> >  
> > +post-patch:
> > +	${REINPLACE_CMD} -e 's|O4|O3|' ${WRKSRC}/${MAKEFILE}
> > +
> 
> I recall this is not the first similar fix.  Is there reason not to uphold
> ${CFLAGS} here instead?

CFLAGS as set by the user are used:

cc -O2 -pipe -fno-strict-aliasing  -O3 -I/src -DVAD1 -std=gnu99
-Qunused-arguments -fstack-protector  -c decoder.c

I see no reason, however, not to let the author supersede them with more
appropriate flags.

-- 
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20121203/7717b20d/attachment.sig>