svn commit: r303150 - head/www/mod_auth_cas

Alexey Dokuchaev danfe at FreeBSD.org
Sat Aug 25 18:18:57 UTC 2012


On Sat, Aug 25, 2012 at 07:31:10PM +0200, Olli Hauer wrote:
> On 2012-08-25 19:02, Alexey Dokuchaev wrote:
> > On Sat, Aug 25, 2012 at 04:48:55PM +0000, Olli Hauer wrote:
> >> New Revision: 303150
> >> URL: http://svn.freebsd.org/changeset/ports/303150
> >>
> >> +post-install:
> >> +	@${CAT} ${PKGMESSAGE}
> >> +
> > 
> > cat(1)ing ${PKGMESSAGE} in post-install could benefit from being
> > surrounded by ${ECHO_MSG}'s on both sides.  This makes installation
> > from port and package behave similarly.
> 
> I agree, thats why I always add a line with ========... at the top and at
> the bottom and have at last one whitespace before the text.
> Instead two times ${ECHO_MSG} I would prefer an additional empty line at
> the top/bottom in pkg-message.

Hmm, last time I checked (couple of years ago), padding pkg-message[.in]
file itself would result in \n emitted twice upon pkg_add(1).  That said,
the only way is to use ${ECHO_MSG} before and after.  Yes, it is ugly, and
ultimately should be fixed (if not already).

./danfe



More information about the svn-ports-all mailing list