PERFORCE change 178075 for review
Hans Petter Selasky
hselasky at c2i.net
Tue May 11 00:04:08 UTC 2010
On Tuesday 11 May 2010 01:35:49 Hans Petter Selasky wrote:
> usb_hub.c:
>
> - overload the "bandwidth_reclaimed" bit-flag, which should
> only be used for the UHCI. When used with the EHCI it
> means we have allocated bandwidth for a high speed endpoint. This bit is
> checked when allocating and freeing to avoid duplicate operations. At
> least the close method of a USB transfer type can be called two times in a
> row, with only one open, due to the current design.
>
s/close/xxx_device_done/
Close should always be paired with open. What I had in mind was the
ehci_device_done() method, which can be called multiple times. And hence
neither of any allocations/freeing is done from that function, the double-call
check can be removed (is superfluous)
--HPS
More information about the p4-projects
mailing list