PERFORCE change 180026 for review

[Garrett Cooper]

On Sun, Jun 20, 2010 at 6:15 PM, Ivan Voras <ivoras at freebsd.org> wrote:
> On 21 June 2010 02:58, Julien LAFFAYE <jlaffaye at freebsd.org> wrote:
>> Hi,
>>
>> On Sun, Jun 20, 2010 at 5:45 PM, Ivan Voras <ivoras at freebsd.org> wrote:
>>>
>>> http://p4web.freebsd.org/@@180026?ac=10
>>>
>>> Change 180026 by ivoras at betelgeuse on 2010/06/21 00:45:03
>>>
>>>        Finished most of +CONTENTS reading code, still a few things to go
>>>        and certainly edge-cases resulting from the uglyness and adhockery
>>>        of the format.
>>>
>>
>> Why don't you use read_plist(Package *pkg, int fd) from libpkg instead?
>
> Should I, in the light of
> YES_I_KNOW_THE_API_IS_RUBBISH_AND_IS_DOOMED_TO_CHANGE ? I thought the
> entire lib is to be rightfully scrapped and implemented as something
> decent.

    Yes, it will be eventually, but there's no real harm in
implementing this bit with read_plist for the time being though. If
and when dforsyth's work gets straightened out, a lot of this crud
will get scrapped and/or properly rewritten.
Thanks,
-Garrett