PERFORCE change 179341 for review

[Ben Fiedler]

>
> >
> > +DEBUG = -g
> >  PROG=  diff
> >  SRCS=  diff.c diffdir.c diffreg.c
> > -CFLAGS+=       -std=c99 -Wall -pedantic
> > +CFLAGS+=       -std=c99 -Wall -pedantic $(DEBUG)
>
> That's what the DEBUG_FLAG var does?
>

Ah, so it does.  Thanks.

>
>
> >
> > -int     aflag, bflag, dflag, iflag, lflag, Nflag, Pflag, pflag, rflag;
> > +int     aflag, Bflag, bflag, dflag, iflag, lflag, Nflag, Pflag, pflag,
> rflag;
>
> This could make merging patches entertaining if you add or remove a
> variable; it probably would be easier if each variable was per-line.
>
> A decent point. I suppose I can do them all on newlines for now..


>
> >  int     sflag, tflag, Tflag, wflag;
> >  int     format, context, status;
>
> ...
>
> > +                   strcmp(dent1->d_name, dent2->d_name) ;
>
> This is kind of hard to read... can this be split up into if-based
> branch statements?
>

It easily could be split; I was just trying to adhere to the already-present
style.


-Ben