PERFORCE change 179074 for review

Garrett Cooper gcooper at FreeBSD.org
Wed Jun 2 07:56:26 UTC 2010


http://p4web.freebsd.org/@@179074?ac=10

Change 179074 by gcooper at gcooper-bayonetta on 2010/06/02 07:56:01

	kientzle is right. I should use ssize_t instead of off_t for the sake
	of semantic correctness.

Affected files ...

.. //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/file.c#21 edit
.. //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/pkg.h#14 edit

Differences ...

==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/file.c#21 (text+ko) ====

@@ -269,13 +269,13 @@
  * Return the number of bytes successfully written out to str or -1 on
  * failure.
  */
-off_t
+ssize_t
 write_file(const char *name, const char *str)
 {
 	int fd = -1;
 	int serrno;
-	off_t written_len = -1;
 	size_t len;
+	ssize_t written_len = -1;
 
 	errno = 0;
 
@@ -291,7 +291,7 @@
 
 	}
 
-	return (off_t) (errno == 0 && written_len > 0 ? written_len : -1);
+	return (errno == 0 && written_len > 0 ? written_len : -1);
 
 }
 

==== //depot/projects/soc2007/gcooper-pkg_install-enhancements-simplified/lib/libpkg/pkg.h#14 (text+ko) ====

@@ -175,7 +175,7 @@
 const char	*fileGetURL(const char *, const char *, int);
 char		*fileFindByPath(const char *, const char *);
 char		*fileGetContents(const char *);
-off_t		write_file(const char *, const char *);
+ssize_t		write_file(const char *, const char *);
 int		move_file(const char *, const char *, const char *);
 int		delete_hierarchy(const char *, Boolean, Boolean);
 char*		unpack_to_buffer(const char *, const char *);


More information about the p4-projects mailing list