PERFORCE change 181154 for review

[Julien LAFFAYE]

On Mon, Jul 19, 2010 at 1:18 AM, Garrett Cooper <gcooper at freebsd.org> wrote:
> Wouldn't it make more sense for extract_package to be in libpkg,
> because it's basically a utility function that would be used by
> pkg_add and pkg_complete?
pkg_add will deal with both regular and complete packages.
pkg_complete is only for the creation of complete packages.
But it wont hurt to move this function into libpkg I suppose.

>
> Also, Tim and I discussed initializing the decompressor only once
> because it would greatly simplify the code in libpkg today, and would
> eliminate wasted CPU cycles used when initializing the decompressor
> each time a metadata file is extracted from the archive object.

Totally agree. Which line(s) of code are you referring to?
Because I'm not aware of re-initializing it every time (maybe a high
level libarchive function?)

>
> Sorry to be a wanker on this too, but considering that all of the code
> moved over from extract.c is basically `new code', could it be cleaned
> up for style(9)?
Yeah, I tried to fix the code while moving it but I must admit that it
wasn't the first goal.
Wanted to check if the whole function worked, eww :p
Again, any particular rules of style(9) in mind ?

>
> Thanks,
> -Garrett
>