PERFORCE change 173596 for review

Robert Watson rwatson at FreeBSD.org
Sat Jan 23 22:25:17 UTC 2010


http://p4web.freebsd.org/chv.cgi?CH=173596

Change 173596 by rwatson at rwatson_cinnamon on 2010/01/23 22:25:15

	Don't allow VOP_SETATTR() on fdescfs -- we could build up a capability
	rights mask for the operations it represents, but it actually isn't very
	coherent conceptually.  For example, you can chmod /dev/fd/X if that fd
	refers to a file, but if you stat() you don't see the file's mode.

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/sys/fs/fdescfs/fdesc_vnops.c#8 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/sys/fs/fdescfs/fdesc_vnops.c#8 (text+ko) ====

@@ -391,6 +391,8 @@
 		struct ucred *a_cred;
 	} */ *ap;
 {
+
+#if 0
 	struct vnode *vp = ap->a_vp;
 	struct vattr *vap = ap->a_vap;
 
@@ -430,6 +432,9 @@
 
 	vp->v_type = vap->va_type;
 	return (0);
+#else
+	return (EOPNOTSUPP);
+#endif
 }
 
 static int


More information about the p4-projects mailing list