PERFORCE change 173002 for review

Hans Petter Selasky hselasky at FreeBSD.org
Mon Jan 11 23:01:00 UTC 2010


http://p4web.freebsd.org/chv.cgi?CH=173002

Change 173002 by hselasky at hselasky_laptop001 on 2010/01/11 23:00:40

	
	USB controller:
		- optimise EHCI ISOC HS done check.
		- patch by HPS.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#47 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/controller/ehci.c#47 (text+ko) ====

@@ -1340,25 +1340,22 @@
 		}
 	} else if (methods == &ehci_device_isoc_hs_methods) {
 		ehci_itd_t *td;
+		uint8_t n = (xfer->nframes & 7);
 
 		/* isochronous high speed transfer */
 
+		/* check last transfer */
 		td = xfer->td_transfer_last;
 		usb_pc_cpu_invalidate(td->page_cache);
-		status =
-		    td->itd_status[0] | td->itd_status[1] |
-		    td->itd_status[2] | td->itd_status[3] |
-		    td->itd_status[4] | td->itd_status[5] |
-		    td->itd_status[6] | td->itd_status[7];
+		if (n == 0)
+			status = td->itd_status[7];
+		else
+			status = td->itd_status[n-1];
 
 		/* also check first transfer */
 		td = xfer->td_transfer_first;
 		usb_pc_cpu_invalidate(td->page_cache);
-		status |=
-		    td->itd_status[0] | td->itd_status[1] |
-		    td->itd_status[2] | td->itd_status[3] |
-		    td->itd_status[4] | td->itd_status[5] |
-		    td->itd_status[6] | td->itd_status[7];
+		status |= td->itd_status[0];
 
 		/* if no transactions are active we continue */
 		if (!(status & htohc32(sc, EHCI_ITD_ACTIVE))) {


More information about the p4-projects mailing list