PERFORCE change 174962 for review
Hans Petter Selasky
hselasky at FreeBSD.org
Mon Feb 22 08:49:34 UTC 2010
http://p4web.freebsd.org/chv.cgi?CH=174962
Change 174962 by hselasky at hselasky_laptop001 on 2010/02/22 08:48:42
USB serial:
- bugfix for uvisor driver
- it appears that some UVISOR devices do not
handle when the clear stall command is issued at
the beginning of the initial IN/OUT data transfers.
Reason unknown, probably firmware fault. After patch
stall is only cleared on data transfer errors.
PR: usb/144199
Affected files ...
.. //depot/projects/usb/src/sys/dev/usb/serial/uvisor.c#17 edit
Differences ...
==== //depot/projects/usb/src/sys/dev/usb/serial/uvisor.c#17 (text+ko) ====
@@ -345,11 +345,6 @@
DPRINTF("could not allocate all pipes\n");
goto detach;
}
- /* clear stall at first run */
- mtx_lock(&sc->sc_mtx);
- usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_WR]);
- usbd_xfer_set_stall(sc->sc_xfer[UVISOR_BULK_DT_RD]);
- mtx_unlock(&sc->sc_mtx);
error = ucom_attach(&sc->sc_super_ucom, &sc->sc_ucom, 1, sc,
&uvisor_callback, &sc->sc_mtx);
More information about the p4-projects
mailing list