PERFORCE change 177488 for review

Alexander Motin mav at FreeBSD.org
Thu Apr 29 20:29:58 UTC 2010


http://p4web.freebsd.org/@@177488?ac=10

Change 177488 by mav at mav_mavtest on 2010/04/29 20:29:56

	Correctly handle cam_sim_alloc() error.

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/dev/mvs/mvs.c#19 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/dev/mvs/mvs.c#19 (text+ko) ====

@@ -156,9 +156,10 @@
 	    2, (ch->quirks & MVS_Q_GENI) ? 0 : MVS_MAX_SLOTS - 1,
 	    devq);
 	if (ch->sim == NULL) {
+		cam_simq_free(devq);
 		device_printf(dev, "unable to allocate sim\n");
 		error = ENOMEM;
-		goto err2;
+		goto err1;
 	}
 	if (xpt_bus_register(ch->sim, dev, 0) != CAM_SUCCESS) {
 		device_printf(dev, "unable to register xpt bus\n");


More information about the p4-projects mailing list