PERFORCE change 176621 for review

[Rafal Jaworowski]

On 2010-04-08, at 14:57, John Baldwin wrote:

> On Wednesday 07 April 2010 11:02:27 am Rafal Jaworowski wrote:
>> http://p4web.freebsd.org/@@176621?ac=10
>> 
>> Change 176621 by raj at raj_fdt on 2010/04/07 15:02:20
>> 
>> 	Provide PCI-E defines.
>> 
>> Affected files ...
>> 
>> .. //depot/projects/fdt/sys/dev/pci/pcireg.h#3 edit
>> 
>> Differences ...
>> 
>> ==== //depot/projects/fdt/sys/dev/pci/pcireg.h#3 (text+ko) ====
>> 
>> @@ -218,6 +218,17 @@
>> 
>> #define	PCIR_PCCARDIF_2	0x44
>> 
>> +
>> +/* PCIE registers */
>> +#define PCIR_DCR	0x54
>> +#define PCIM_DCR_URR	0x0008
>> +#define PCIM_DCR_FER	0x0004
>> +#define PCIM_DCR_NFER	0x0002
>> +#define PCIR_DSR	0x56
>> +#define PCIR_LTSSM	0x404
>> +#define PCIM_LTSSM_L0	0x16
> 
> Err, are you sure about these?  Generally the PCI-e registers are part of the 
> PCI-e capability and are not a fixed offset.  Also, we already have constants 
> for various PCI-e registers in pcireg.h like so:
> 
> /* PCI Express definitions */

Thanks for pointing out. Let me look into improving and cleaning up this (primarily I was just moving existing defines which we had locally in mpc85xx PCI into a shared location without too deep thought).

Rafal