PERFORCE change 168633 for review

Jung-uk Kim jkim at FreeBSD.org
Thu Sep 17 19:27:33 UTC 2009


http://perforce.freebsd.org/chv.cgi?CH=168633

Change 168633 by jkim at jkim_hammer on 2009/09/17 19:27:10

	Improve syscall trace for fcntl(2) F_DUP2FD command.

Affected files ...

.. //depot/projects/valgrind/coregrind/m_syswrap/syswrap-freebsd.c#41 edit

Differences ...

==== //depot/projects/valgrind/coregrind/m_syswrap/syswrap-freebsd.c#41 (text+ko) ====

@@ -3064,7 +3064,6 @@
    case VKI_F_SETFD:
    case VKI_F_SETFL:
    case VKI_F_SETOWN:
-   case VKI_F_DUP2FD:
       PRINT("sys_fcntl[ARG3=='arg'] ( %ld, %ld, %ld )", ARG1,ARG2,ARG3);
       PRE_REG_READ3(long, "fcntl",
                     unsigned int, fd, unsigned int, cmd, unsigned long, arg);
@@ -3082,6 +3081,15 @@
                     struct oflock *, lock);
       break;
 
+   // This one uses ARG3 as "oldd" and ARG4 as "newd".
+   case VKI_F_DUP2FD:
+      PRINT("sys_fcntl[ARG3=='oldd', ARG4=='newd'] ( %ld, %ld, %ld, %ld )",
+         ARG1,ARG2,ARG3,ARG4);
+      PRE_REG_READ4(long, "fcntl",
+                    unsigned int, fd, unsigned int, cmd,
+                    unsigned long, oldd, unsigned long, newd);
+      break;
+
    // These ones use ARG3 as "lock".
    case VKI_F_SETLKW:
       *flags |= SfMayBlock;


More information about the p4-projects mailing list