PERFORCE change 170842 for review

Nathan Whitehorn nwhitehorn at freebsd.org
Thu Nov 19 23:16:23 UTC 2009


Hans Petter Selasky wrote:
> http://p4web.freebsd.org/chv.cgi?CH=170842
>
> Change 170842 by hselasky at hselasky_laptop001 on 2009/11/19 22:34:49
>
> 	
> 	USB input:
> 		 - ATP patch from Rohit Grover:
> 		   - fixes some minor issues and
> 		     makes the control transfer
> 		     fully asynchronous
>
>
>   
[...]
> @@ -1530,7 +1574,7 @@
>  		return (ENXIO);
>  
>  	if (usbd_lookup_id_by_uaa(atp_devs, sizeof(atp_devs), uaa) == 0)
> -		return BUS_PROBE_SPECIFIC;
> +		return 0;
>  	else
>  		return ENXIO;
>  }
Why are you replacing symbolic constants with less informative numeric ones?
-Nathan


More information about the p4-projects mailing list