PERFORCE change 170348 for review

Hans Petter Selasky hselasky at FreeBSD.org
Sun Nov 8 10:55:39 UTC 2009


http://p4web.freebsd.org/chv.cgi?CH=170348

Change 170348 by hselasky at hselasky_laptop001 on 2009/11/08 10:54:42

	
	LibUSB v1.0 - fix a possible device leak.

Affected files ...

.. //depot/projects/usb/src/lib/libusb/libusb10.c#14 edit

Differences ...

==== //depot/projects/usb/src/lib/libusb/libusb10.c#14 (text+ko) ====

@@ -186,8 +186,6 @@
 	/* create libusb v1.0 compliant devices */
 	i = 0;
 	while ((pdev = libusb20_be_device_foreach(usb_backend, NULL))) {
-		/* get device into libUSB v1.0 list */
-		libusb20_be_dequeue_device(usb_backend, pdev);
 
 		dev = malloc(sizeof(*dev));
 		if (dev == NULL) {
@@ -200,6 +198,10 @@
 			libusb20_be_free(usb_backend);
 			return (LIBUSB_ERROR_NO_MEM);
 		}
+
+		/* get device into libUSB v1.0 list */
+		libusb20_be_dequeue_device(usb_backend, pdev);
+
 		memset(dev, 0, sizeof(*dev));
 
 		/* init transfer queues */


More information about the p4-projects mailing list