PERFORCE change 166785 for review

John Baldwin jhb at FreeBSD.org
Thu Jul 30 12:44:02 UTC 2009


http://perforce.freebsd.org/chv.cgi?CH=166785

Change 166785 by jhb at jhb_jhbbsd on 2009/07/30 12:43:09

	Remove extraneous locking to read fd_cmask in one other place.
	The rest of the tree already read fd_cmask w/o locking.

Affected files ...

.. //depot/projects/smpng/sys/fs/unionfs/union_subr.c#39 edit

Differences ...

==== //depot/projects/smpng/sys/fs/unionfs/union_subr.c#39 (text+ko) ====

@@ -486,9 +486,7 @@
 		}
 		break;
 	default:		/* UNIONFS_TRADITIONAL */
-		FILEDESC_SLOCK(td->td_proc->p_fd);
 		uva->va_mode = 0777 & ~td->td_proc->p_fd->fd_cmask;
-		FILEDESC_SUNLOCK(td->td_proc->p_fd);
 		uva->va_uid = ump->um_uid;
 		uva->va_gid = ump->um_gid;
 		break;


More information about the p4-projects mailing list