PERFORCE change 156688 for review

John Baldwin jhb at FreeBSD.org
Mon Jan 26 07:30:05 PST 2009


http://perforce.freebsd.org/chv.cgi?CH=156688

Change 156688 by jhb at jhb_jhbbsd on 2009/01/26 15:29:33

	Revert this from here.

Affected files ...

.. //depot/projects/smpng/sys/fs/udf/udf_vfsops.c#41 edit

Differences ...

==== //depot/projects/smpng/sys/fs/udf/udf_vfsops.c#41 (text+ko) ====

@@ -319,9 +319,11 @@
 	struct g_consumer *cp;
 	struct bufobj *bo;
 
+	DROP_GIANT();
 	g_topology_lock();
 	error = g_vfs_open(devvp, &cp, "udf", 0);
 	g_topology_unlock();
+	PICKUP_GIANT();
 	VOP_UNLOCK(devvp, 0);
 	if (error)
 		return error;
@@ -361,9 +363,11 @@
 
 	if (((logical_secsize % cp->provider->sectorsize) != 0) ||
 	    (logical_secsize < cp->provider->sectorsize)) {
+		DROP_GIANT();
 		g_topology_lock();
 		g_vfs_close(cp);
 		g_topology_unlock();
+		PICKUP_GIANT();
 		return (EINVAL);
 	}
 
@@ -487,9 +491,11 @@
 		free(udfmp, M_UDFMOUNT);
 	if (bp != NULL)
 		brelse(bp);
+	DROP_GIANT();
 	g_topology_lock();
 	g_vfs_close(cp);
 	g_topology_unlock();
+	PICKUP_GIANT();
 	return error;
 };
 
@@ -516,9 +522,11 @@
 #endif
 	}
 
+	DROP_GIANT();
 	g_topology_lock();
 	g_vfs_close(udfmp->im_cp);
 	g_topology_unlock();
+	PICKUP_GIANT();
 	vrele(udfmp->im_devvp);
 
 	if (udfmp->s_table != NULL)


More information about the p4-projects mailing list