PERFORCE change 155896 for review
Weongyo Jeong
weongyo.jeong at gmail.com
Sun Jan 11 18:05:48 PST 2009
On Sat, Jan 10, 2009 at 11:38:01AM +0100, Hans Petter Selasky wrote:
> On Saturday 10 January 2009, Weongyo Jeong wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=155896
> >
> > Change 155896 by weongyo at weongyo_ws on 2009/01/10 08:59:26
> >
> > In USB 2.0 specification The USB System Software should guarantees
> > a minumum of 10ms for reset recovery but it looks the USB1 framework
> > doesn't follow it. So it looks sometimes it failed to re-attach or
> > reenumerate devices after the device reset.
> >
> > With this patch, the fw loading operation of uath(4) works.
> >
> > Affected files ...
> >
> > .. //depot/projects/vap/sys/dev/usb/usb.c#8 edit
> >
>
> Hi,
>
> This is not the right place to patch.
>
> I think this delay belongs somewhere in "uhub.c". Please search for the
> following defines in the code:
>
> #define USB_PORT_RESET_DELAY 50 /* ms */
> #define USB_PORT_ROOT_RESET_DELAY 250 /* ms */
> #define USB_PORT_RESET_RECOVERY 250 /* ms */
>
> There should already be a delay there. Maybe you need to increase one of these
> macros.
Oops. Ok I'll try to fix it. Thank you for noticing about it.
regards,
Weongyo Jeong
More information about the p4-projects
mailing list