PERFORCE change 155748 for review

[M. Warner Losh]

In message: <200901081839.27124.hselasky at freebsd.org>
            Hans Petter Selasky <hselasky at freebsd.org> writes:
: On Thursday 08 January 2009, M. Warner Losh wrote:
: > In message: <200901071009.n07A9jrs056953 at repoman.freebsd.org>
: >
: >             Hans Petter Selasky <hselasky at freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=155748
: > :
: > : Change 155748 by hselasky at hselasky_laptop001 on 2009/01/07 10:09:35
: > :
: > :
: > : 	Umass module quirk from Alexander Best
: > : 	to support Meizu Electronics MiniPlayer.
: > :
: > : Affected files ...
: > :
: > : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21 edit
: > : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit
: > :
: > : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21
: > : (text+ko) ==== ====
: > : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21
: > : (text+ko) ====
: >
: > Why are these generated files committed to the tree?  We did a lot of
: > work to make usbdevs generated files not need to be committed to the
: > tree and this breaks that...
: >
: > Warner
: 
: Because they are not automatically generated any more.

They are automatically generated.

You mean that they are no longer automatically generated as part of
the build?  I'm wondering why not?  We went to a lot of trouble to dig
out of the problems that causes, and I'd hate to see us go back to the
bad old days...

Warner