PERFORCE change 155748 for review

Hans Petter Selasky hselasky at freebsd.org
Thu Jan 8 19:08:14 UTC 2009


On Thursday 08 January 2009, Remko Lodder wrote:
> On Jan 8, 2009, at 6:39 PM, Hans Petter Selasky wrote:
> > On Thursday 08 January 2009, M. Warner Losh wrote:
> >> In message: <200901071009.n07A9jrs056953 at repoman.freebsd.org>
> >>
> >>            Hans Petter Selasky <hselasky at freebsd.org> writes:
> >> : http://perforce.freebsd.org/chv.cgi?CH=155748
> >> :
> >> : Change 155748 by hselasky at hselasky_laptop001 on 2009/01/07 10:09:35
> >> :
> >> :
> >> : 	Umass module quirk from Alexander Best
> >> : 	to support Meizu Electronics MiniPlayer.
> >> :
> >> : Affected files ...
> >> :
> >> : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#35 edit
> >> : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21
> >>
> >> edit
> >>
> >> : .. //depot/projects/usb/src/sys/dev/usb2/include/
> >>
> >> usb2_devtable.h#21 edit
> >>
> >> : .. //depot/projects/usb/src/sys/dev/usb2/storage/umass2.c#20 edit
> >> :
> >> : ==== //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#21
> >> : (text+ko) ==== ====
> >> : //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#21
> >> : (text+ko) ====
> >>
> >> Why are these generated files committed to the tree?  We did a lot of
> >> work to make usbdevs generated files not need to be committed to the
> >> tree and this breaks that...
> >>
> >> Warner
> >
> > Because they are not automatically generated any more.
> >
> > --HPS
>
> Hmm, I liked the idea of only needing to do something marginally to
> add something. If files are no longer generated automatically and I
> need to do more, I'll look for other low hanging fruit.
>
> In short: can you restore automatic regenerating behaviour?

Hi Remko,

Everything is possible.

How would you explain the benefit of the +19Mbyte of data resulting from this 
autogeneration when building the modules ?

126035 Jan  7 11:12 usb2_devid.h
197224 Jan  7 11:12 usb2_devtable.h

197+126
ans = 323
ans * 60
ans = 19380

--HPS


More information about the p4-projects mailing list