PERFORCE change 150275 for review

[Bjoern A. Zeeb]

http://perforce.freebsd.org/chv.cgi?CH=150275

Change 150275 by bz at bz_dumpster on 2008/09/22 16:47:33

	Remove an XXX locking comment.
	Put back the statics.
	Discussed with:		brooks, rwatson

Affected files ...

.. //depot/projects/vimage-commit2/src/sys/net80211/ieee80211_ddb.c#5 edit
.. //depot/projects/vimage-commit2/src/sys/netinet/tcp_sack.c#8 edit

Differences ...

==== //depot/projects/vimage-commit2/src/sys/net80211/ieee80211_ddb.c#5 (text+ko) ====

@@ -194,7 +194,6 @@
 			break;
 		}
 
-	/* XXX to lock or not to lock the vnet list - we are in DDB here? */
 	VNET_FOREACH(vnet_iter) {
 		INIT_VNET_NET(vnet_iter);
 		TAILQ_FOREACH(ifp, &V_ifnet, if_list)

==== //depot/projects/vimage-commit2/src/sys/netinet/tcp_sack.c#8 (text+ko) ====

@@ -130,17 +130,17 @@
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, enable,
     CTLFLAG_RW, tcp_do_sack, 0, "Enable/Disable TCP SACK support");
 
-int tcp_sack_maxholes = 128;
+static int tcp_sack_maxholes = 128;
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, maxholes,
     CTLFLAG_RW, tcp_sack_maxholes, 0, 
     "Maximum number of TCP SACK holes allowed per connection");
 
-int tcp_sack_globalmaxholes = 65536;
+static int tcp_sack_globalmaxholes = 65536;
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, globalmaxholes,
     CTLFLAG_RW, tcp_sack_globalmaxholes, 0, 
     "Global maximum number of TCP SACK holes");
 
-int tcp_sack_globalholes = 0;
+static int tcp_sack_globalholes = 0;
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, globalholes,
     CTLFLAG_RD, tcp_sack_globalholes, 0,
     "Global number of TCP SACK holes currently allocated");