PERFORCE change 149544 for review

[Sam Leffler]

http://perforce.freebsd.org/chv.cgi?CH=149544

Change 149544 by sam at sam_ebb on 2008/09/10 17:20:33

	correct QoS control field in ampdu subframes; when ampdu
	is negotiated with an immediate BA policy subframes are
	to be marked to have normal acks and not explicit BA's;
	this (apparently) wasn't noticed because existing drivers
	crafted their own QoS ctrl field and/or some receivers
	generate BA regardless of what you stick in there

Affected files ...

.. //depot/projects/vap/sys/net80211/ieee80211_output.c#57 edit

Differences ...

==== //depot/projects/vap/sys/net80211/ieee80211_output.c#57 (text+ko) ====

@@ -1061,8 +1061,12 @@
 			if (IEEE80211_AMPDU_RUNNING(tap)) {
 				/*
 				 * Operational, mark frame for aggregation.
+				 *
+				 * NB: We support only immediate BA's for
+				 * AMPDU which means we set the QoS control
+				 * field to "normal ack" (0) to get "implicit
+				 * block ack" behaviour.
 				 */
-				qos[0] |= IEEE80211_QOS_ACKPOLICY_BA;
 				m->m_flags |= M_AMPDU_MPDU;
 			} else if (!IEEE80211_AMPDU_REQUESTED(tap) &&
 			    ic->ic_ampdu_enable(ni, tap)) {