PERFORCE change 153699 for review

Hans Petter Selasky hselasky at FreeBSD.org
Fri Nov 28 10:07:52 PST 2008


http://perforce.freebsd.org/chv.cgi?CH=153699

Change 153699 by hselasky at hselasky_laptop001 on 2008/11/28 18:07:44

	
	Fix errornous parsing of USB audio mixer data.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb2/sound/uaudio2.c#21 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb2/sound/uaudio2.c#21 (text+ko) ====

@@ -2656,7 +2656,10 @@
 		DPRINTF("invalid Audio Control header\n");
 		goto done;
 	}
-	wTotalLen = UGETW(cd->wTotalLength);
+	/* "wTotalLen" is allowed to be corrupt */
+	wTotalLen = UGETW(acdp->wTotalLength) - acdp->bLength;
+
+	/* get USB audio revision */
 	sc->sc_audio_rev = UGETW(acdp->bcdADC);
 
 	DPRINTFN(3, "found AC header, vers=%03x, len=%d\n",


More information about the p4-projects mailing list