PERFORCE change 146209 for review

Oliver Fromme olli at fromme.com
Wed Jul 30 12:32:27 UTC 2008


Gábor Kövesdán wrote:
 > Kris Kennaway escribió:
 > > Gabor Kovesdan wrote:
 > > > http://perforce.freebsd.org/chv.cgi?CH=146209
 > > >
 > > > Change 146209 by gabor at gabor_server on 2008/07/29 16:01:05
 > > >
 > > >     - Just handle some command line options as noop.  They seem to be
 > > >       rarely used based on the resources describing them.  From now on
 > > >       let's concentrate on the really practical features instead of
 > > >       these ones.
 > > 
 > > I don't think it's a good idea to "implement" options as NOPs unless 
 > > they really are NOPs.  This will just cause silent failure and/or 
 > > script misbehaviour, which may be very hard to track down.
 > 
 > I've been also thinking of this, and I'm still a bit unsure. It would be 
 > bad if scripts failed due to this, but it would be also bad if scripts 
 > didn't run because of a e.g. --side-by-side argument, which rarely (or 
 > never?) makes any difference.

How about printing a fat warning message on stderr that
the option is unsupported and ignored, and then continue
normally?

Best regards
   Oliver

-- 
Oliver Fromme, Bunsenstr. 13, 81735 Muenchen, Germany

``We are all but compressed light'' (Albert Einstein)


More information about the p4-projects mailing list