PERFORCE change 145959 for review

Ed Schouten ed at FreeBSD.org
Sat Jul 26 10:49:14 UTC 2008


http://perforce.freebsd.org/chv.cgi?CH=145959

Change 145959 by ed at ed_dull on 2008/07/26 10:48:18

	I think we want to call finit() at the bottom. I don't want to
	know the strange things that could happen when the descriptor
	would be closed, while we're still creating the device node in
	make_dev().

Affected files ...

.. //depot/projects/mpsafetty/sys/dev/pts/pts.c#5 edit

Differences ...

==== //depot/projects/mpsafetty/sys/dev/pts/pts.c#5 (text+ko) ====

@@ -532,11 +532,11 @@
 
 	tp = tty_alloc(&pts_class, psc, NULL);
 
-	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
-
 	/* Expose the slave device as well */
 	tty_makedev(tp, td->td_ucred, "pts/%u", psc->pts_unit);
 
+	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
+
 	return (0);
 }
 
@@ -559,10 +559,10 @@
 
 	tp = tty_alloc(&pts_class, psc, NULL);
 
-	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
-
 	/* Expose the slave device as well */
 	tty_makedev(tp, td->td_ucred, "%s", name);
+
+	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
 }
 #endif /* PTS_EXTERNAL */
 


More information about the p4-projects mailing list