PERFORCE change 144842 for review

[M. Warner Losh]

In message: <200807071855.m67ItHQp084707 at repoman.freebsd.org>
            Marcel Moolenaar <marcel at freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=144842
: 
: Change 144842 by marcel at marcel_xcllnt on 2008/07/07 18:55:11
: 
: 	ISA_PNP_PROBE() can also return ENOENT.
: 	So, assume a match when the error is 0, not != ENXIO.
: 
: Affected files ...
: 
: .. //depot/projects/uart/dev/uart/uart_bus_isa.c#13 edit
: 
: Differences ...
: 
: ==== //depot/projects/uart/dev/uart/uart_bus_isa.c#13 (text+ko) ====
: 
: @@ -170,7 +170,7 @@
:  	sc = device_get_softc(dev);
:  
:  	/* Probe PnP _and_ non-PnP ns8250 here. */
: -	if (ISA_PNP_PROBE(parent, dev, isa_ns8250_ids) != ENXIO) {
: +	if (ISA_PNP_PROBE(parent, dev, isa_ns8250_ids) == 0) {
:  		sc->sc_class = &uart_ns8250_class;
:  		return (uart_bus_probe(dev, 0, 0, 0, 0));
:  	}

I don't think this change is correct.

ISA_PNP_PROBE returns 0 when there is a PNPID for this device, and
there is a match in the table.

ISA_PNP_PROBE returns ENXIO when there is a PNPID for this device and
there is no match in the table.

ISA_PNP_PROBE returns ENOENT when there's no PNPID for this device.

Warner