PERFORCE change 144741 for review

Takahashi Yoshihiro nyan at jp.FreeBSD.org
Sun Jul 6 02:10:16 UTC 2008


In article <200807051943.m65JhHZ6066371 at repoman.freebsd.org>
Marcel Moolenaar <marcel at freebsd.org> writes:

>  static struct isa_pnp_id isa_i8251_ids[] = {
>  	{0x0100e4a5, "RSA-98III"},
>  	{0}
>  };

>  	/* Probe PnP _and_ non-PnP i8251 here. */
>  	if (ISA_PNP_PROBE(parent, dev, isa_i8251_ids) != ENXIO) {
>  		sc->sc_class = &uart_i8251_class;
>  		return (uart_bus_probe(dev, 0, 0, 0, 0));
>  	}

These are wrong.  RSA98-III is based on ns8250 and has extended FIFO
buffer.  So I think that the uart_rsa_class should be added.

FYI, RSA series are not for pc98 only.
RSA-PCI (PCI) and RSA-DVII (ISA) exist but not supported yet.

---
TAKAHASHI Yoshihiro <nyan at jp.FreeBSD.org>


More information about the p4-projects mailing list