PERFORCE change 133557 for review

Warner Losh imp at FreeBSD.org
Fri Jan 18 08:58:40 PST 2008


http://perforce.freebsd.org/chv.cgi?CH=133557

Change 133557 by imp at imp_paco-paco on 2008/01/18 16:58:22

	Add a nop to prevent macro expanding into delay slot of blt.  The
	target of the blt also loads the per cpu stuff (into t0), so there's
	no need to put it in the delay slot.  One might be able to tweak
	the code a little to load it always and have the leaf code cope,
	but I'm not sure if the leaf that's called is called only from here
	so I'm just doing the correct thing and noting the posbilty that more
	analysis could yield more optimal results.

Affected files ...

.. //depot/projects/mips2-jnpr/src/sys/mips/mips/support.S#6 edit

Differences ...

==== //depot/projects/mips2-jnpr/src/sys/mips/mips/support.S#6 (text+ko) ====

@@ -1466,6 +1466,7 @@
 
 	li	t0, VM_MAXUSER_ADDRESS /* verify address validity */
 	blt	a0, t0, fusufault		/* trap faults */
+	nop
 
 	GET_CPU_PCPU(t1)
 	lw	t1, PC_CURTHREAD(t1)


More information about the p4-projects mailing list