PERFORCE change 133522 for review
Bruce M. Simpson
bms at FreeBSD.org
Fri Jan 18 06:23:03 PST 2008
Warner Losh wrote:
> http://perforce.freebsd.org/chv.cgi?CH=133522
>
> Change 133522 by imp at imp_paco-paco on 2008/01/18 05:25:09
>
> Prefer ${SHELL} to sh, since I like it. Sadly, I got complaints
> when I proposed it for -current.
>
The source of the objection might be that GNU make is known to prefer
bash -- and I've torn my hair out on more than one occasion because of
this behaviour.
However, buildenv is a target which explicitly forks an interactive
shell, so the use of SHELL seems reasonable in this instance.
cheers
BMS
More information about the p4-projects
mailing list