PERFORCE change 132497 for review

M. Warner Losh imp at bsdimp.com
Sun Jan 6 12:33:22 PST 2008


In message: <200801041343.19320.jhb at freebsd.org>
            John Baldwin <jhb at freebsd.org> writes:
: On Friday 04 January 2008 01:19:26 pm M. Warner Losh wrote:
: > In message: <200801041711.m04HBGPG029002 at repoman.freebsd.org>
: >             Oleksandr Tymoshenko <gonzo at freebsd.org> writes:
: > : http://perforce.freebsd.org/chv.cgi?CH=132497
: > : 
: > : Change 132497 by gonzo at gonzo_jeeves on 2008/01/04 17:11:07
: > : 
: > : 	o I believe MK_ZFS is more appropriate variable to be checked
: > : 	    in this case.
: > 
: > I thought this was more a case of 'exclude all CDDL code' rather than
: > being tied to ZFS.
: > 
: > Warner
: 
: I dunno, I think gonzo@ might be right.  It's ZFS support for fstat and I 
: think disabling CDDL would disable ZFS as a side effect?

In any event, these changes should be made in head, not here.

Warner

: > : Affected files ...
: > : 
: > : .. //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 edit
: > : 
: > : Differences ...
: > : 
: > : ==== //depot/projects/mips2-jnpr/src/usr.bin/fstat/Makefile#2 (text+ko) 
: ====
: > : 
: > : @@ -13,7 +13,7 @@
: > :  
: > :  CFLAGS+=-D_KVM_VNODE
: > :  
: > : -.if ${MK_CDDL} != "no"
: > : +.if ${MK_ZFS} != "no"
: > :  CFLAGS+= -DZFS
: > :  OBJS+= zfs/zfs.o
: > :  SUBDIR=	zfs
: > : 
: > 
: 
: 
: 
: -- 
: John Baldwin
: 


More information about the p4-projects mailing list