PERFORCE change 136373 for review

Steve Wise swise at FreeBSD.org
Wed Feb 27 22:35:29 UTC 2008


http://perforce.freebsd.org/chv.cgi?CH=136373

Change 136373 by swise at swise:vic10:iwarp on 2008/02/27 22:35:25

	Fixed recursive lock bugs.

Affected files ...

.. //depot/projects/iwarp/sys/contrib/rdma/krping/krping.c#10 edit
.. //depot/projects/iwarp/sys/contrib/rdma/rdma_iwcm.c#9 edit

Differences ...

==== //depot/projects/iwarp/sys/contrib/rdma/krping/krping.c#10 (text+ko) ====

@@ -308,12 +308,10 @@
 		  cb->remote_rkey, (unsigned long long)cb->remote_addr, 
 		  cb->remote_len);
 
-	mtx_lock_spin(&cb->lock);
 	if (cb->state <= CONNECTED || cb->state == RDMA_WRITE_COMPLETE)
 		cb->state = RDMA_READ_ADV;
 	else
 		cb->state = RDMA_WRITE_ADV;
-	mtx_unlock_spin(&cb->lock);
 
 	return 0;
 }
@@ -326,12 +324,10 @@
 		return -1;
 	}
 
-	mtx_lock_spin(&cb->lock);
 	if (cb->state == RDMA_READ_ADV)
 		cb->state = RDMA_WRITE_ADV;
 	else
 		cb->state = RDMA_WRITE_COMPLETE;
-	mtx_unlock_spin(&cb->lock);
 
 	return 0;
 }

==== //depot/projects/iwarp/sys/contrib/rdma/rdma_iwcm.c#9 (text+ko) ====

@@ -957,9 +957,7 @@
 		}
 	}
 
-	mtx_lock_spin(&cm_id_priv->lock);
 	atomic_inc(&cm_id_priv->refcount);
-	mtx_unlock_spin(&cm_id_priv->lock);
 	if (TAILQ_EMPTY(&cm_id_priv->work_list)) {
 		TAILQ_INSERT_TAIL(&cm_id_priv->work_list, work, list);
 		taskqueue_enqueue(iwcm_wq, &work->task);


More information about the p4-projects mailing list