PERFORCE change 136193 for review
Sam Leffler
sam at FreeBSD.org
Mon Feb 25 23:18:09 UTC 2008
http://perforce.freebsd.org/chv.cgi?CH=136193
Change 136193 by sam at sam_ebb on 2008/02/25 23:17:59
drop lock around call to ioctl handler to bring the
parent interface up; this causes troubles for drivers
that download firmware in their init method; in theor
firmware should be downloaded on vap create but there
may be other reasons to remove this restriction
Affected files ...
.. //depot/projects/vap/sys/net80211/ieee80211_proto.c#22 edit
Differences ...
==== //depot/projects/vap/sys/net80211/ieee80211_proto.c#22 (text+ko) ====
@@ -1099,8 +1099,10 @@
IEEE80211_MSG_STATE | IEEE80211_MSG_DEBUG,
"%s: up parent %s\n", __func__, parent->if_xname);
parent->if_flags |= IFF_UP;
- /* XXX holding lock */
+ /* XXX drop lock */
+ IEEE80211_UNLOCK(ic);
parent->if_ioctl(parent, SIOCSIFFLAGS, NULL);
+ IEEE80211_LOCK(ic);
}
/*
* Mark us running. Note that we do this after
More information about the p4-projects
mailing list