PERFORCE change 135099 for review
John Birrell
jb at FreeBSD.org
Sat Feb 9 01:35:48 PST 2008
http://perforce.freebsd.org/chv.cgi?CH=135099
Change 135099 by jb at jb_freebsd1 on 2008/02/09 09:34:53
In the great tradition of the undocumented clone_create()
interface, if you pass a pointer to an uninitialised
variable, you can get a panic "foo".
Yes, "foo".
This didn't happen on amd64, but it seems to happen all
the time on i386.
A closer inspection of the code in sys/kern/kern_conf.c
shows that the variable should have been set to -1.
Sigh.
Affected files ...
.. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_clone.c#9 edit
Differences ...
==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_clone.c#9 (text+ko) ====
@@ -32,7 +32,7 @@
static void
dtrace_clone(void *arg, struct ucred *cred, char *name, int namelen, struct cdev **dev)
{
- int u;
+ int u = -1;
size_t len;
if (*dev != NULL)
More information about the p4-projects
mailing list