PERFORCE change 134792 for review

Robert Watson rwatson at FreeBSD.org
Mon Feb 4 09:56:48 PST 2008


http://perforce.freebsd.org/chv.cgi?CH=134792

Change 134792 by rwatson at rwatson_freebsd_capabilities on 2008/02/04 17:56:38

	Update comments.

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/sys/kern/sys_capability.c#12 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/sys/kern/sys_capability.c#12 (text+ko) ====

@@ -41,7 +41,7 @@
  */
 
 #include <sys/cdefs.h>
-__FBSDID("$P4: //depot/projects/trustedbsd/capabilities/src/sys/kern/sys_capability.c#11 $");
+__FBSDID("$P4: //depot/projects/trustedbsd/capabilities/src/sys/kern/sys_capability.c#12 $");
 
 #include <sys/param.h>
 #include <sys/capability.h>
@@ -69,8 +69,9 @@
 };
 
 /*
- * XXXRW: This is inadequate, as there are some VFS and socket operations
- * that are not handled via fileops.
+ * Capabilities have a fileops vector, but in practice none should ever be
+ * called except for fo_close, as the capability will normally not be
+ * returned during a file descriptor lookup in the system call code.
  */
 static fo_rdwr_t capability_read;
 static fo_rdwr_t capability_write;
@@ -126,8 +127,6 @@
  * pointer in *fp will remain valid, so no extra reference management is
  * required, and the caller should fdrop() fp_cap as normal when done with
  * both.
- *
- * XXXRW: This will almost certainly change.
  */
 int
 cap_fextract(struct file *fp_cap, cap_rights_t rights, struct file **fpp)


More information about the p4-projects mailing list