PERFORCE change 134677 for review

[John Birrell]

http://perforce.freebsd.org/chv.cgi?CH=134677

Change 134677 by jb at jb_freebsd1 on 2008/02/02 22:27:05

	I prefer to have the probe arguments to a syscall return
	probe match the entry probe. This avoids having to probe and
	entry call and save stuff in local variables for use in the
	return probe. The error variable is saved in the thread
	structure anyway (and is on Solaris too -- the DTrace test
	suite checks that), so it doesn't been to be passed in as
	the return probe arguments when there are more useful things
	to pass.

Affected files ...

.. //depot/projects/dtrace/src/sys/amd64/amd64/trap.c#22 edit
.. //depot/projects/dtrace/src/sys/i386/i386/trap.c#27 edit
.. //depot/projects/dtrace7/src/sys/amd64/amd64/trap.c#5 edit

Differences ...

==== //depot/projects/dtrace/src/sys/amd64/amd64/trap.c#22 (text+ko) ====

@@ -903,10 +903,6 @@
 		td->td_errno = error;
 
 #ifdef KDTRACE_HOOKS
-		/* Save the error return variable for DTrace to reference. */
-		args[0] = error;
-		args[1] = error;
-
 		/*
 		 * If the systrace module has registered it's probe
 		 * callback and if there is a probe active for the

==== //depot/projects/dtrace/src/sys/i386/i386/trap.c#27 (text+ko) ====

@@ -1086,10 +1086,6 @@
 		td->td_errno = error;
 
 #ifdef KDTRACE_HOOKS
-		/* Save the error return variable for DTrace to reference. */
-		args[0] = error;
-		args[1] = error;
-
 		/*
 		 * If the systrace module has registered it's probe
 		 * callback and if there is a probe active for the

==== //depot/projects/dtrace7/src/sys/amd64/amd64/trap.c#5 (text+ko) ====

@@ -903,10 +903,6 @@
 		td->td_errno = error;
 
 #ifdef KDTRACE_HOOKS
-		/* Save the error return variable for DTrace to reference. */
-		args[0] = error;
-		args[1] = error;
-
 		/*
 		 * If the systrace module has registered it's probe
 		 * callback and if there is a probe active for the