PERFORCE change 126374 for review

Constantine A. Murenin cnst at FreeBSD.org
Thu Sep 13 12:52:16 PDT 2007


http://perforce.freebsd.org/chv.cgi?CH=126374

Change 126374 by cnst at dale on 2007/09/13 19:51:24

	the invalid flag usually means all fields are invalid,
	not just the value field

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#10 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#10 (text+ko) ====

@@ -418,14 +418,17 @@
 		return (1);
 	}
 
-	if (s->flags & SENSOR_FINVALID)
+	if (s->flags & SENSOR_FINVALID) {
 		/*
 		 * XXX: with this flag, the node should be entirely ignored,
 		 * but as the magic-based sysctl(8) is not too flexible, we
 		 * simply have to print out that the sensor is invalid.
 		 */
 		printf("invalid");
-	else if (s->flags & SENSOR_FUNKNOWN)
+		return (0);
+	}
+
+	if (s->flags & SENSOR_FUNKNOWN)
 		printf("unknown");
 	else {
 		switch (s->type) {


More information about the p4-projects mailing list