PERFORCE change 119266 for review
Matt Jacob
mjacob at FreeBSD.org
Sat May 5 05:12:18 UTC 2007
http://perforce.freebsd.org/chv.cgi?CH=119266
Change 119266 by mjacob at mjexp on 2007/05/05 05:11:37
First part of this- don't call isp_reinit from interrupt context.
Affected files ...
.. //depot/projects/mjexp/sys/dev/isp/isp.c#20 edit
Differences ...
==== //depot/projects/mjexp/sys/dev/isp/isp.c#20 (text+ko) ====
@@ -5121,20 +5121,11 @@
isp->isp_mboxtmp[0] = MBOX_HOST_INTERFACE_ERROR;
MBOX_NOTIFY_COMPLETE(isp);
}
-#ifdef ISP_FW_CRASH_DUMP
/*
- * If we have crash dumps enabled, it's up to the handler
- * for isp_async to reinit stuff and restart the firmware
- * after performing the crash dump. The reason we do things
- * this way is that we may need to activate a kernel thread
- * to do all the crash dump goop.
+ * It's up to the handler for isp_async to reinit stuff and
+ * restart the firmware
*/
isp_async(isp, ISPASYNC_FW_CRASH, NULL);
-#else
- isp_async(isp, ISPASYNC_FW_CRASH, NULL);
- isp_reinit(isp);
- isp_async(isp, ISPASYNC_FW_RESTARTED, NULL);
-#endif
rval = -1;
break;
@@ -5401,13 +5392,7 @@
break;
case ISP_CONN_FATAL:
isp_prt(isp, ISP_LOGERR, "FATAL CONNECTION ERROR");
-#ifdef ISP_FW_CRASH_DUMP
isp_async(isp, ISPASYNC_FW_CRASH, NULL);
-#else
- isp_async(isp, ISPASYNC_FW_CRASH, NULL);
- isp_reinit(isp);
- isp_async(isp, ISPASYNC_FW_RESTARTED, NULL);
-#endif
return (-1);
case ISP_CONN_LOOPBACK:
isp_prt(isp, ISP_LOGWARN,
More information about the p4-projects
mailing list