PERFORCE change 115381 for review

Paolo Pisati piso at freebsd.org
Mon Mar 5 23:06:32 UTC 2007


On Mon, Mar 05, 2007 at 11:01:28PM +0000, Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=115381
> 
> Change 115381 by piso at piso_newluxor on 2007/03/05 23:01:11
> 
> 	Restore the sos's intendation style.
> 
> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/ata/ata-pci.c#7 edit
> .. //depot/projects/soc2006/intr_filter/dev/scc/scc_core.c#15 edit
> 
> Differences ...
> 
[snip] 
> ==== //depot/projects/soc2006/intr_filter/dev/scc/scc_core.c#15 (text) ====
> 
> @@ -535,8 +535,8 @@
>  	if (device_get_parent(child) != dev)
>  		return (EINVAL);
>  
> -	/* Interrupt handlers must be FAST or MPSAFE. */
> -	if ((filter == NULL) && !(flags & INTR_MPSAFE))
> +	/* Interrupt handlers must be FILTER or MPSAFE. */
> +	if ((ihand != NULL) && !(flags & INTR_MPSAFE))
>  		return (EINVAL);
>  
>  	sc = device_get_softc(dev);

This should be:

o properly check for FILTER or MPSAFE handler.

bye,
P.


More information about the p4-projects mailing list