PERFORCE change 123699 for review
Constantine A. Murenin
cnst at FreeBSD.org
Thu Jul 19 03:53:25 UTC 2007
On 18/07/2007 13:28, Maxim Zhuravlev wrote:
> http://perforce.freebsd.org/chv.cgi?CH=123699
>
> Change 123699 by thioretic at thioretic on 2007/07/18 17:27:28
>
> Just some load code for DR_REQDEV drivers.
>
> Affected files ...
>
> .. //depot/projects/soc2007/thioretic_gidl/kern/subr_bus.c#17 edit
>
> Differences ...
>
> ==== //depot/projects/soc2007/thioretic_gidl/kern/subr_bus.c#17 (text+ko) ====
>
> @@ -4662,8 +4662,8 @@
> drv_internal_t drv_intnl;
> kobj_class_t driver;
> char* parents[];
> - int count=0, isfilter;
> - device_t dev;
> + int count=0, isfilter, devcount;
> + device_t dev, *devices;
>
> dmd = (struct driver_module_data *)arg;
> drv_intnl = dmd->dmd_driver;
> @@ -4702,14 +4702,14 @@
> parentname = driver->baseclasses[0]->name;
> *dmd->dmd_devclass =
> devclass_find_internal(driver->name,
> - parentname, TRUE);
> + parentname, TRUE, FALSE);
> } else {
> *dmd->dmd_devclass =
> - devclass_find_internal(driver->name, 0, TRUE);
> + devclass_find_internal(driver->name, 0, TRUE, FALSR);
typo? If FALSR is not a typo but an actual constant, I would suggest
renaming it in such a way that it won't look like it is meant to be
typed as FALSE. :)
Cheers,
Constantine.
More information about the p4-projects
mailing list