PERFORCE change 113667 for review

Roman Divacky rdivacky at FreeBSD.org
Mon Jan 29 13:55:03 UTC 2007


http://perforce.freebsd.org/chv.cgi?CH=113667

Change 113667 by rdivacky at rdivacky_witten on 2007/01/29 13:54:58

	We dont have to lock emul_lock in exit_group() because em->shared
	cannot change (because its referenced by curthread). This fixes
	a LOR caused by acquiring emul_shared_lock while holding emul_lock.
	While here fix typo in comment.

Affected files ...

.. //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#53 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/compat/linux/linux_misc.c#53 (text+ko) ====

@@ -1617,7 +1617,7 @@
 #endif
 
 	if (linux_use26(td)) {
-		td_em = em_find(td->td_proc, EMUL_DOLOCK);
+		td_em = em_find(td->td_proc, EMUL_DONTLOCK);
 
 		KASSERT(td_em != NULL, ("exit_group: emuldata not found.\n"));
 
@@ -1635,11 +1635,10 @@
 		}
 
 		EMUL_SHARED_RUNLOCK(&emul_shared_lock);
-		EMUL_UNLOCK(&emul_lock);
 	}
 	/*
 	 * XXX: we should send a signal to the parent if
-	 * SIGNAL_EXIT_GROUP is set. We ignore that (temporrarily?)
+	 * SIGNAL_EXIT_GROUP is set. We ignore that (temporarily?)
 	 * as it doesnt occur often.
 	 */
 	exit1(td, W_EXITCODE(args->error_code, 0));


More information about the p4-projects mailing list