PERFORCE change 112535 for review

[Divacky Roman]

On Tue, Jan 09, 2007 at 01:17:06PM -0500, John Baldwin wrote:
> > > > @@ -237,12 +237,10 @@
> > > >  
> > > >  	pr = td->td_ucred->cr_prison;
> > > >  	if (pr != NULL) {
> > > > -		mtx_lock(&pr->pr_mtx);
> > > >  		if (pr->pr_linux != NULL) {
> > > >  			lpr = (struct linux_prison *)pr->pr_linux;
> > > >  			use26 = lpr->pr_use_linux26;
> > > >  		}
> > > > -		mtx_unlock(&pr->pr_mtx);
> > > >  	} else
> > > >  		use26 = linux_use_linux26;
> > > >  	
> > > > 
> > > 
> > > Hmm, what is use26 set to if pr != NULL but pr->pr_linux == NULL?
> > 
> > to the default value of 0
> 
> Shouldn't it be set to linux_use_26 in that case?

as I understand the code such condition should not happen under
normal condition and is a sign of something bad's going on.

so its better to be safe and not enable the "higher" emulation.
the point is - a defined value is returned and it even happens
to be the same value (0) as the linux_use_26.