PERFORCE change 112427 for review

Olivier Houchard cognet at FreeBSD.org
Tue Jan 2 10:23:28 PST 2007


http://perforce.freebsd.org/chv.cgi?CH=112427

Change 112427 by cognet at hulglah on 2007/01/02 18:22:41

	Ooops, revert the logic : don't disable the interrupt unless it's
	really needed.
	Suggested by:	jhb

Affected files ...

.. //depot/projects/soc2006/intr_filter/arm/arm/intr.c#11 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/arm/arm/intr.c#11 (text+ko) ====

@@ -123,12 +123,12 @@
 }
 
 static void
-intr_eoi_src(void *arg)
+intr_disab_eoi_src(void *arg)
 {
 	uintptr_t nb;
 
 	nb = (uintptr_t)arg;
-	arm_unmask_irq(nb);
+	arm_mask_irq(nb);
 }
 
 void
@@ -139,16 +139,14 @@
 
 	PCPU_LAZY_INC(cnt.v_intr);
 	while ((i = arm_get_next_irq()) != -1) {
-		arm_mask_irq(i);
 		intrcnt[intrcnt_tab[i]]++;
 		event = intr_events[i];
-		res = mi_handle_intr(event, frame, intr_eoi_src, 
-				     intr_disab_eoi_src_stub, (void *)i);
+		res = mi_handle_intr(event, frame, intr_eoi_src_stub, 
+				     intr_disab_eoi_src, (void *)i);
 		switch (res) {
 		case 0:
 			break;
 		case ECHILD:
-			arm_unmask_irq(i);
 			break;
 		case EFAULT:
 			/* FALLTHROUGH */


More information about the p4-projects mailing list