PERFORCE change 112379 for review
John Baldwin
jhb at freebsd.org
Tue Jan 2 09:22:29 PST 2007
On Sunday 31 December 2006 18:53, Roman Divacky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=112379
>
> Change 112379 by rdivacky at rdivacky_witten on 2006/12/31 23:53:30
>
> Implement SETALL/GETALL IPC primitives. This fixes some LTP testcases.
Are you sure it's actually working? I thought Linux semid structure was a
different size, and GETALL and SETALL try to copyin and copyout data from
userland without doing any conversions.
> Affected files ...
>
> .. //depot/projects/linuxolator/src/sys/compat/linux/linux_ipc.c#8 edit
>
> Differences ...
>
> ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_ipc.c#8 (text+ko) ====
>
> @@ -571,9 +571,13 @@
> td->td_retval[0] = seminfo.semmni;
> return 0; /* No need for __semctl call */
> case LINUX_GETALL:
> - /* FALLTHROUGH */
> + cmd = GETALL;
> + semun.val = args->arg.val;
> + break;
> case LINUX_SETALL:
> - /* FALLTHROUGH */
> + cmd = SETALL;
> + semun.val = args->arg.val;
> + break;
> default:
> linux_msg(td, "ipc type %d is not implemented",
> args->cmd & ~LINUX_IPC_64);
>
--
John Baldwin
More information about the p4-projects
mailing list