PERFORCE change 132000 for review
Garrett Cooper
gcooper at FreeBSD.org
Sat Dec 29 16:48:26 PST 2007
http://perforce.freebsd.org/chv.cgi?CH=132000
Change 132000 by gcooper at shiina-ibook on 2007/12/30 00:47:46
- pkg_action_null's a noop function. So why does it have to be interactive?
- Trim down the __unused's..
Affected files ...
.. //depot/projects/soc2007/revised_fbsd_pkgtools/pkg_revised/v2/contrib/libpkg/pkg_db.c#5 edit
Differences ...
==== //depot/projects/soc2007/revised_fbsd_pkgtools/pkg_revised/v2/contrib/libpkg/pkg_db.c#5 (text+ko) ====
@@ -107,17 +107,12 @@
/**
* @brief The package action used when no output is required
- * Andrew:
- * @todo Change to follow the interactive flag
- * Garrett:
- * This isn't necessary I think, and should stick with
- * the interface, not with the library.
*
* This is a function that does nothing.
* It can be used for a pkg_action when no output is required
*/
void
-pkg_action_null(enum pkg_action_level level __unused, const char *fmt __unused,
+pkg_action_null(enum pkg_action_level level, const char *fmt,
...)
{
}
@@ -313,7 +308,7 @@
* @return 0
*/
int
-pkg_match_all(struct pkg *pkg __unused, const void *data __unused)
+pkg_match_all(struct pkg *pkg, const void *data)
{
return 0;
}
More information about the p4-projects
mailing list