PERFORCE change 131926 for review

M. Warner Losh imp at bsdimp.com
Fri Dec 28 15:40:15 PST 2007


In message: <200712282257.lBSMvPQi030689 at repoman.freebsd.org>
            Hans Petter Selasky <hselasky at freebsd.org> writes:
: http://perforce.freebsd.org/chv.cgi?CH=131926
: 
: Change 131926 by hselasky at hselasky_laptop001 on 2007/12/28 22:56:35
: 
: 	
: 	Looks like the wrong mask is used. Not sure if it
: 	has any practical effect. Please correct me if this
: 	patch is wrong. At least the OHCI and AT91 UDP works
: 	regardless of this patch.

I think this is right.  It works because we force the pmc mask to
0xffffffff elsewhere.

Warner

: Affected files ...
: 
: .. //depot/projects/usb/src/sys/arm/at91/at91_pmc.c#5 edit
: 
: Differences ...
: 
: ==== //depot/projects/usb/src/sys/arm/at91/at91_pmc.c#5 (text) ====
: 
: @@ -128,7 +128,7 @@
:  static struct at91_pmc_clock ohci_clk = {
:  	.name = "ohci_clk",
:  	.parent = &mck,
: -	.pmc_mask = 1 << AT91RM92_IRQ_UDP,
: +	.pmc_mask = 1 << AT91RM92_IRQ_UHP,
:  	.set_mode = &at91_pmc_set_periph_mode
:  };


More information about the p4-projects mailing list