PERFORCE change 130807 for review

Hans Petter Selasky hselasky at FreeBSD.org
Thu Dec 13 11:18:38 PST 2007


http://perforce.freebsd.org/chv.cgi?CH=130807

Change 130807 by hselasky at hselasky_laptop001 on 2007/12/13 19:17:39

	
	Only clear the PORT_ENABLE feature on the HUB
	if the port is enabled. Else it has been observed
	that some HUBs will generate another port connection
	change and we start going into an infinite loop.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/uhub.c#26 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/uhub.c#26 (text+ko) ====

@@ -420,8 +420,10 @@
 		child = NULL;
 	}
 	if (err == 0) {
+		if (sc->sc_st.port_status & UPS_PORT_ENABLED) {
 		err = usbreq_clear_port_feature
 		    (sc->sc_udev, &usb_global_lock, portno, UHF_PORT_ENABLE);
+		}
 	}
 	if (err) {
 		DPRINTF(sc, -1, "device problem (%s), "


More information about the p4-projects mailing list