PERFORCE change 129943 for review

Hans Petter Selasky hselasky at FreeBSD.org
Sat Dec 1 17:13:59 PST 2007


http://perforce.freebsd.org/chv.cgi?CH=129943

Change 129943 by hselasky at hselasky_laptop001 on 2007/12/02 01:13:50

	
	Remove some alignment requirements. We assume that all 
	USB DMA hardware supports byte aligment.

Affected files ...

.. //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#57 edit

Differences ...

==== //depot/projects/usb/src/sys/dev/usb/usb_transfer.c#57 (text+ko) ====

@@ -403,28 +403,6 @@
 	} else {
 
 		/*
-		 * BSD specific requirement:
-		 *
-		 * In case we are transferring more than one USB frame
-		 * consisting of up to 3 USB packets, make sure that the USB
-		 * frame size is divisible by 8. This is supposed to
-		 * optimize the USB Host Controller by avoiding unaligned
-		 * data accesses!
-		 */
-
-		if (parm->bufsize > xfer->max_frame_size) {
-
-			while (xfer->max_frame_size & 7) {
-				if (xfer->max_packet_size == parm->hc_max_packet_size) {
-					/* should not happen */
-					parm->err = USBD_INVAL;
-					goto done;
-				}
-				(xfer->max_packet_size)++;
-				usbd_compute_max_frame_size(xfer);
-			}
-		}
-		/*
 		 * if a value is specified use that else check the endpoint
 		 * descriptor
 		 */


More information about the p4-projects mailing list